Expose agent chat lifecycle APIs#171
Conversation
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several enhancements to the registry broker client, including new functionality for chat readiness checks, message retries, and session cancellation. It also updates the session termination process to return structured responses and expands Zod schemas and TypeScript types to support new fields such as idempotency keys, visibility settings, and delivery states. The review feedback suggests adding robust input validation and string trimming for identifiers and payload properties across the new methods to prevent malformed API requests.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f0b4b1af4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 40bf0f5e91
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 720732fe9f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Michael Kantor <6068672+kantorcodes@users.noreply.github.com>
1 participant
Shipped behavior
Verification
pnpm run lint— passed.pnpm run typecheck— passed.pnpm exec jest --config jest.config.json --coverage=false --runTestsByPath __tests__/services/registry-broker-client.test.ts --runInBand— passed, 40 tests.pnpm run build— passed.Docker/local e2e
Command:
cd ../registry-broker && docker compose --profile extras up -d elasticsearch rocksdb-sidecar qdrant registry-broker ping-agent && pnpm run e2e:agent-chatResult: registration status 200 from register-endpoint; readiness responsive/a2a/direct; session ready; send responded with assistant_response; idempotent duplicate returned same message id; history roles user and agent; retry responded; end-session ended.